This repository has been archived by the owner on May 3, 2024. It is now read-only.
@link(url: String!) argument is non-null
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
requested review from
dariuszkuc and
sachindshinde
as code owners
SimonSapin
changed the title
@link(url: String!) argument is non-null
|
My mistake, I made this PR too quickly. It was the comment that was wrong, so I fixed that now. |
goto-bus-stop
approved these changes
Feb 22, 2024
Merged
goto-bus-stop
added a commit
that referenced
this pull request
Mar 6, 2024
For API schema in router 🤞🏻 ## Features - Support legacy `@core` link syntax, by [goto-bus-stop] in [pull/224] This is not meant to be a long term feature, `@core()` is not intended to be supported in most of the codebase. ## Maintenance - `@link(url: String!)` argument is non-null, by [SimonSapin] in [pull/220] - Enable operation normalization tests using `@defer`, by [goto-bus-stop] in [pull/224] [SimonSapin]: https://github.com/SimonSapin [goto-bus-stop]: https://github.com/goto-bus-stop [pull/220]: #220 [pull/223]: #223 [pull/224]: #224
SimonSapin
added a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
SimonSapin
pushed a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
For API schema in router 🤞🏻 ## Features - Support legacy `@core` link syntax, by [goto-bus-stop] in [pull/224] This is not meant to be a long term feature, `@core()` is not intended to be supported in most of the codebase. ## Maintenance - `@link(url: String!)` argument is non-null, by [SimonSapin] in [pull/220] - Enable operation normalization tests using `@defer`, by [goto-bus-stop] in [pull/224] [SimonSapin]: https://github.com/SimonSapin [goto-bus-stop]: https://github.com/goto-bus-stop [pull/220]: apollographql/federation-next#220 [pull/223]: apollographql/federation-next#223 [pull/224]: apollographql/federation-next#224
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec: https://specs.apollo.dev/link/v1.0/#@link.url