This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix: more compatible definitions added by include_{defer,stream}
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a rather silly mistake in the `@defer` definition: it applies to fragment spreads, but I copy-pasted wrong and made it apply to fields instead. That's fixed here. I also removed the doc comments from the definitions. The JS code did not add them and having them messes up the comparison between JS and Rust results in the router. If it's any use to have it, we can re-add it later when the JS implementation is gone.
goto-bus-stop
requested review from
dariuszkuc and
sachindshinde
as code owners
dariuszkuc
approved these changes
Feb 21, 2024
SimonSapin
pushed a commit
to apollographql/router
that referenced
this pull request
May 3, 2024
…pollographql/federation-next#221) There was a rather silly mistake in the `@defer` definition: it applies to fragment spreads, but I copy-pasted wrong and made it apply to fields instead. That's fixed now. I also removed the doc comments from the definitions. The JS code did not add them and having them messes up the comparison between JS and Rust results in the router. If it's any use to have it, we can re-add it later when the JS implementation is gone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a rather silly mistake in the
@deferdefinition: it applies to fragment spreads, but I copy-pasted wrong and made it apply to fields instead. That's fixed now.I also removed the doc comments from the definitions. The JS code did not add them and having them messes up the comparison between JS and Rust results in the router. If it's any use to have it, we can re-add it later when the JS implementation is gone.