-
Notifications
You must be signed in to change notification settings - Fork 242
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip some supergraph validations in production by default (#2657)
Stop running the full suite of graphQL validations on supergraphs and their extracted subgraphs by default in production environment. Running those validations on every updates of the schema takes a non-negligible amount of time (especially on large schema) and mainly only serves in catching bugs early in the supergraph handling code, and in some limited cases, provide slightly better messages when a corrupted supergraph is received, neither of which is worth the cost in production environment. A new `validateSupergraph` option is also introduced in the gateway configuration to force this behaviour. Co-authored-by: Chris Lenfest <clenfest@apollographql.com> Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
- Loading branch information
1 parent
8f3c301
commit fe1e3d7
Showing
7 changed files
with
82 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
"@apollo/query-planner": minor | ||
"@apollo/query-graphs": minor | ||
"@apollo/composition": minor | ||
"@apollo/federation-internals": minor | ||
"@apollo/gateway": minor | ||
--- | ||
|
||
Do not run the full suite of graphQL validations on supergraphs and their extracted subgraphs by default in production environment. | ||
|
||
Running those validations on every updates of the schema takes a non-negligible amount of time (especially on large | ||
schema) and mainly only serves in catching bugs early in the supergraph handling code, and in some limited cases, | ||
provide slightly better messages when a corrupted supergraph is received, neither of which is worth the cost in | ||
production environment. | ||
|
||
A new `validateSupergraph` option is also introduced in the gateway configuration to force this behaviour. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters