Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to changesets for release management #1846

Closed
benweatherman opened this issue May 11, 2022 · 2 comments · Fixed by #1936
Closed

Move to changesets for release management #1846

benweatherman opened this issue May 11, 2022 · 2 comments · Fixed by #1936
Assignees
@clenfest
Labels
⛲️ feature
Milestone
2.3.0

Comments

@benweatherman
Copy link
Contributor

benweatherman commented May 11, 2022 •
edited
Loading

Apollo is adopting changesets across a lot of our projects and lerna was recently deprecated (though there's perhaps life left for lerna). Federation should likely follow the lead and start using changesets.

There's an example repo that could help guide us through the transition and apollo-utils is using it.

Some things to consider:

  1. Will this allow us to bump versions in lockstep? Currently we bump all package versions together and will need to support that.
  2. How do we make sure it's easy for contributions? We should make sure our docs on how to submit changes are accurate and up-to-date.
@benweatherman benweatherman added this to the 2.1.0 milestone May 11, 2022
@cpeacock cpeacock modified the milestones: 2.1.0, 2.2, 2.2.0 May 24, 2022
@benweatherman benweatherman changed the title Move to changsets for release management Move to changesets for release management Jun 8, 2022
@benweatherman
Copy link
Contributor Author

Note that implementing this would fix #1815 as well

@benweatherman benweatherman mentioned this issue Jun 28, 2022
Closed
benweatherman added a commit that referenced this issue Jun 28, 2022
@benweatherman
Add changesets
f2a5b27 
Followed examples from [Apollo's own `@apollographql/typescript-repo-template`](https://github.com/apollographql/typescript-repo-template#changesets) and [straight from the `changesets` docs](https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md#versioning-and-publishing)

- Updated `RELEASING.md` to reflect the move to `changesets`
- Updated `CONTRIBUTING.md` to be more succinct and hopefully more helpful
- Removed `DEVELOPMENT.md` since it's all about how to do the previous incarnation of publishing
- Removed `lerna` stuff

Fixes #1846
@benweatherman benweatherman mentioned this issue Jun 28, 2022
Merged
@jeffjakub jeffjakub modified the milestones: 2.2.0, 2.3.0 Jan 6, 2023
clenfest added a commit that referenced this issue Jan 10, 2023
@benweatherman @clenfest
Add changesets (#1936)
fde8c8e 
* Add changesets

Followed examples from [Apollo's own `@apollographql/typescript-repo-template`](https://github.com/apollographql/typescript-repo-template#changesets) and [straight from the `changesets` docs](https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md#versioning-and-publishing)

- Updated `RELEASING.md` to reflect the move to `changesets`
- Updated `CONTRIBUTING.md` to be more succinct and hopefully more helpful
- Removed `DEVELOPMENT.md` since it's all about how to do the previous incarnation of publishing
- Removed `lerna` stuff

Fixes #1846

Co-authored-by: Chris Lenfest <clenfest@apollographql.com>
@benweatherman
Copy link
Contributor Author

Nice work @clenfest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clenfest clenfest

Labels
⛲️ feature
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

Add changesets apollographql/federation
4 participants
@benweatherman @jeffjakub @cpeacock @clenfest