Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-planner-js): buildComposedSchema doesn't preserve @deprecated usages on input values #635

Closed
trevor-scheer opened this issue Apr 2, 2021 · 1 comment · Fixed by #996

Comments

@trevor-scheer
Copy link
Member

Reported by @sachindshinde - specifically calling printSchema(buildComposedSchema(parse(supergraphSdl))) loses @deprecated usages on input values.

@trevor-scheer trevor-scheer self-assigned this Apr 2, 2021
@glasser
Copy link
Member

glasser commented Apr 2, 2021

What exactly do you mean by input values? Arguments definitions, input field definitions, or both?

Are we positive the loss is in buildComposedSchema rather than printSchema, or both?

(Note that support of these two features is still unmerged in the graphql-spec (graphql/graphql-spec#805) although I do believe graphql-js already implements them.)

Is this just a matter of porting some changes from graphql-js to our copy/paste?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants