Duplicate Parallel calls to federated services with Federation 2

[AneethAnand]

Query planner generates - Duplicate parallel calls to the federated services
Repository to reproduce the error (https://github.com/AneethAnand/federation2)

Graphql Query

query test {
      viewer {
        user {
          user1
          user2
          id
          user3
          network {
                  id
              network1
          }
          user4
          user5
          user6
          user7
          user8
        }
        viewer1
        viewer2
        viewer3
    }
}

Actual QueryPlan

QueryPlan {
  Parallel {
    Fetch(service: "A1") {
      {
        viewer {
          user {
            user1
            user2
            id
            user3
            network {
              id
              network1
            }
            user4
            user5
            user6
            user7
            user8
          }
          viewer1
          viewer2
          viewer3
        }
      }
    },
    Fetch(service: "V1") {
      {
        viewer {
          user {
            user2
            id
            user3
            network {
              id
              network1
            }
            user4
            user5
            user6
            user7
            user8
          }
          viewer1
          viewer2
          viewer3
        }
      }
    },
  },
}

Expectation

    Fetch(service: "A1") {
      {
        viewer {
          user {
            user1
            user2
            id
            user3
            network {
              id
              network1
            }
            user4
            user5
            user6
            user7
            user8
          }
          viewer1
          viewer2
          viewer3
        }
      }
    }

Remove one of the field say "viewer3" in the query, the gateway works as expected.

QueryPlan {
  Fetch(service: "A1") {
    {
      viewer {
        user {
          user1
          user2
          id
          user3
          network {
            id
            network1
          }
          user4
          user5
          user6
          user7
          user8
        }
        viewer1
        viewer2
      }
    }
  },
}

[pcmanus]

Thanks for the report and sorry for the inconvenience. Created #1319 with a fix.

[AneethAnand]

@pcmanus Can you publish the changes for the fix? I dont see the change reflected in "2.0.0-alpha.2"

[AneethAnand]

@abernix / @pcmanus Can you tell me how can I point query-planner dependency to your private federation mono-repo? I tried using query-planner-js's package.json but it is dependent on internal-js and query-graph. Not sure if the federation repo has a package.json that points to all those 3 folders.

[abernix]

@AneethAnand Those are all referenced in this repository. This code doesn't live in any private federation monorepo. What you might be looking for is a release to be cut that includes this fix, which is something that hasn't yet been done but I understand should be coming in the next couple days. (Is that right, @pcmanus?)

federation/package.json

Lines 34 to 44 in 950eb93

	"dependencies": {
	"@apollo/composition": "file:composition-js",
	"@apollo/federation-internals": "file:internals-js",
	"@apollo/gateway": "file:gateway-js",
	"@apollo/harmonizer": "file:harmonizer",
	"@apollo/query-graphs": "file:query-graphs-js",
	"@apollo/query-planner": "file:query-planner-js",
	"@apollo/router-bridge": "file:router-bridge",
	"@apollo/subgraph": "file:subgraph-js",
	"apollo-federation-integration-testsuite": "file:federation-integration-testsuite-js"
	},

[cpeacock]

@AneethAnand We should be cutting that new release sometime this week.

[AneethAnand]

Thanks for the update @abernix and @cpeacock !

[pcmanus]

@AneethAnand Sorry for the delay, but 2.0.0-alpha.3 was published on Friday and contains that fix if you'd like to give it a shot. Thanks again for the report!

[AneethAnand]

@pcmanus No problem I saw the newer version published on Friday and we have already started using it. Thanks again!