Add missing introspection fields and fix isPromise prisma compatiblility #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
hayes
force-pushed
the
mh--update-introspection-and-fix-isPromise
branch
2 times, most recently
from
c606f3a
to
6cdbc6d
Compare
hayes
force-pushed
the
mh--update-introspection-and-fix-isPromise
branch
from
6cdbc6d
to
1c03bd8
Compare
benweatherman
suggested changes
Mar 24, 2022
There was a problem hiding this comment.
Thank you for this excellent contribution! The code is great, though it would be ideal if we could create a separate PR for the promise check vs the introspection change. Any chance you'd be willing to do that? I hate to ask you to do extra work, but I've done it anyway 😸
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
benweatherman
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1578, #1579
The isPromise fix is related to prisma/prisma#12252.
It should probably be fixed in both places. Since prisma promises seem to work correctly with most other libraries (graphql-js, or just native await) making it work here too is probably correct, even though not correctly handling an
inoperation is kinda weird.