Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @link in the supergraph #1628

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

pcmanus
Copy link
Contributor

@pcmanus pcmanus commented Mar 21, 2022

Generates supergraph with @link directives instead of @core ones.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pcmanus
Copy link
Contributor Author

pcmanus commented Mar 21, 2022

Unfortunately, this change is breaking for preview.

I initially though it wasn't because testing prior query planner version against the new supergraphs from this patch worked/works, but unfortunately calling the toAPISchema on the new supergraph from versions before this patch fails due to this part of the code unfortunately checking the 'feature' argument by name, argument that is renamed to 'url' for @link.

Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 left an unimportant comment, do with it as you wish

composition-js/src/merging/merge.ts Outdated Show resolved Hide resolved
Co-authored-by: weatherman <benweatherman@gmail.com>
@netlify
Copy link

netlify bot commented Mar 23, 2022

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit efd6412

@pcmanus pcmanus merged commit 8a9997e into apollographql:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants