Fix merging of renamed @tag directive ... #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmanus
commented
Mar 23, 2022
| } | ||
|
|
||
| const MERGED_FEDERATION_DIRECTIVES: MergedDirectiveInfo[] = [ |
There was a problem hiding this comment.
If someone wonders why this patch is kind of over-generic despite only have 1 merged directive, that's because @inaccessible will be add to this list shortly.
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
added 2 commits
March 24, 2022 16:04
... but requires that it is renamed consistently in all subgraphs.
pcmanus
force-pushed
the
fix-renamed-tag-merging
branch
from
e75dd98
to
61b452c
Compare
clenfest
approved these changes
Mar 24, 2022
And for the record, I agree with that questioning. This PR is meant to be a stop-gap until we figure out the full rules we want for merging core directives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but requires that it is renamed consistently in all subgraphs.