Add support for tag v0.2 #1652
Merged
Add support for tag v0.2 #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pcmanus
approved these changes
Mar 28, 2022
| @@ -173,7 +189,7 @@ export function typeIncludesDirective( | |||
| directiveName: string, | |||
| ): boolean { | |||
| if (isInputObjectType(type)) return false; | |||
| const directives = gatherDirectives(type as GraphQLNamedTypeWithDirectives); | |||
There was a problem hiding this comment.
We probably want to remove the special case for isInputObjectType just before this line? (I'll note that this method is only used internally in the case of object types, so doesn't matter so far for our internal usage, but since it's exported ...).
sachindshinde
force-pushed
the
fed2/tag-v0.2-updates
branch
2 times, most recently
from
f9f2349
to
ec0ee3b
Compare
sachindshinde
force-pushed
the
fed2/tag-v0.2-updates
branch
from
ec0ee3b
to
dff6b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tag v0.2, which adds support for
@tagin more locations (arguments, scalars, enums, enum values, input objects, input object fields).