Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax validation of directive redefinition for scalar #1674

Merged

Conversation

pcmanus
Copy link
Contributor

@pcmanus pcmanus commented Apr 4, 2022

No description provided.

@netlify
Copy link

netlify bot commented Apr 4, 2022

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit dfe5a24

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pcmanus pcmanus force-pushed the directive-redefinition-relaxing branch from b24efa0 to d262fb4 Compare April 4, 2022 17:16
Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐 I left some comments, in case they spark any thoughts for changes. Though this seems great to merge as-is.

@pcmanus pcmanus force-pushed the directive-redefinition-relaxing branch from d262fb4 to 313ae53 Compare April 5, 2022 08:30
@pcmanus pcmanus force-pushed the directive-redefinition-relaxing branch from 313ae53 to dfe5a24 Compare April 5, 2022 08:38
@pcmanus pcmanus merged commit ac2737f into apollographql:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants