Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __resolveType to _Entity union #1773

Merged
merged 6 commits into from Apr 25, 2022
Merged

Add __resolveType to _Entity union #1773

merged 6 commits into from Apr 25, 2022

Conversation

michael-watson
Copy link
Contributor

This fixes issue #1772

Main use case addMocksToSchema form @graphql-tools/mocks
@netlify
Copy link

netlify bot commented Apr 25, 2022

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f317428

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trevor-scheer
Copy link
Member

@michael-watson can we close out #411 and #348 with this PR?

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add a changelog entry to the subgraph-js/CHANGELOG.md please?

@trevor-scheer trevor-scheer merged commit db90d54 into apollographql:main Apr 25, 2022
trevor-scheer added a commit that referenced this pull request Apr 25, 2022
Co-authored-by: Michael Watson <xambrew@gmail.com>
@michael-watson
Copy link
Contributor Author

michael-watson commented Apr 25, 2022

Yes @trevor-scheer, I believe we can close #411 and #348. The default mock options in ApolloServer will work for mocks: true, mockEntireSchema: false. It translates directly to addMocksToSchema with the preserveResolver options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants