Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify fed2 composition rules for enums #2011

Merged

Conversation

StephenBarlow
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 25, 2022

鈥硷笍 Deploy request for apollo-federation-docs rejected.

Name Link
馃敤 Latest commit 2fd3306

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I added a few small suggestions, but feel free to take/leave them!

docs/source/federated-types/composition.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/composition.mdx Outdated Show resolved Hide resolved
StephenBarlow and others added 3 commits July 25, 2022 16:01
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃悙

@jeffjakub jeffjakub self-requested a review July 26, 2022 16:13
@jeffjakub
Copy link
Contributor

This looks great, thanks Stephen.

@StephenBarlow
Copy link
Contributor Author

Thanks all!

@StephenBarlow StephenBarlow merged commit 4275648 into apollographql:main Jul 26, 2022
@StephenBarlow StephenBarlow deleted the sb/clarify-enum-composition branch July 26, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants