Ensures key fields needed post-@require are fetched #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
approved these changes
Aug 18, 2022
added 2 commits
August 18, 2022 16:08
Sometimes, a `@require` on some entity `E` in some subgraph A requires that the query plan jumps from A to some other subgraph(s) to get the requirements, and then that we use a key of `E` to jump back to A to resume fetching the field having the `@require`. When that happens the code was correctly finding the key need to do that "post-@require" resuming, and was using it as "inputs" of the post-@require fetch, but was assuming that those key fields had already fetched. And while that's true in a number of situation, this is not guaranteed. This fix ensures that we force fetching (pre-@require) those key fields that are needed to resume post-@require. Fixes apollographql#2069
pcmanus
force-pushed
the
f2069-requires-missing-fields
branch
from
2a78acb
to
c93f851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, a
@requireon some entityEin some subgraph A requiresthat the query plan jumps from A to some other subgraph(s) to get the
requirements, and then that we use a key of
Eto jump back to A toresume fetching the field having the
@require. When that happensthe code was correctly finding the key need to do that "post-@require"
resuming, and was using it as "inputs" of the post-@require fetch,
but was assuming that those key fields had already fetched. And while
that's true in a number of situation, this is not guaranteed.
This fix ensures that we force fetching (pre-@require) those key
fields that are needed to resume post-@require.
Fixes #2069