Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fragment expansion nuking @defer and other minor @defer updates #2093

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Fix fragment expansion nuking @defer and other minor @defer updates #2093

merged 5 commits into from
Aug 29, 2022

Commits on Aug 29, 2022

  1. Fix fragments extensions nuking @defer

    Sylvain Lebresne committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    36191f7 View commit details
    Browse the repository at this point in the history

  2. Minor @defer updates 

    This address most of the comment from @glasser on apollographql#1958, namely:
- it removes/update some outdated TODOs.
- it fixup the definition of @defer/@stream to match current spec.
- makes serialized query plan for condition hopefully a tad easier to
  parse (solely impact unit tests readability).
- adds a test to ensure that if the same field is queries both "normally"
  and deferred, we do query it twice (that's what spec specifies).
    Sylvain Lebresne committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    5204412 View commit details
    Browse the repository at this point in the history

  3. Tweak the name of the config used to enable @defer in the QP

    Sylvain Lebresne committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    28aaa03 View commit details
    Browse the repository at this point in the history

  4. Adds changelog entries

    Sylvain Lebresne committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7ea2795 View commit details
    Browse the repository at this point in the history

  5. fix bad english

    Sylvain Lebresne committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    e4acca8 View commit details
    Browse the repository at this point in the history