Optimize plan for defer where only keys are fetched #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
reviewed
Oct 11, 2022
| } else { | ||
| const parents = group.parents(); | ||
| const parent = parents[0]; | ||
| if (parents.length === 1 && parent.path) { |
There was a problem hiding this comment.
Just for my understanding, what are the conditions under which a parent wouldn't have a path?
There was a problem hiding this comment.
There is some cases where the path doesn't really make sense at I explained in this comment. But more concretely, it show in code paths at least here and here.
clenfest
approved these changes
Oct 18, 2022
added 2 commits
October 19, 2022 17:40
Router-based defer is based on using an entity key to "resume" the deferred part of a `@defer`, but that means that at least the key(s) needs to be fetched in the non-deferred part. But if only the key were selected in the deferred part, the code was issuing a new deferred fetch to get those key field "again". This commit avoids this by recognizing that those key fields don't need to be fetched again.
pcmanus
force-pushed
the
defer-only-key
branch
from
89bf8e3
to
59f08ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router-based defer is based on using an entity key to "resume" the deferred part of a
@defer, but that means that at least the key(s) needs to be fetched in the non-deferred part. But if only the key were selected in the deferred part, the code was issuing a new deferred fetch to get those key field "again". This commit avoids this by recognizing that those key fields don't need to be fetched again.