Correctly reject field names starting with __
#2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
approved these changes
Nov 8, 2022
pcmanus
pushed a commit
to pcmanus/federation
that referenced
this pull request
Nov 14, 2022
The fix for apollographql#2237 has been a bit over-zealous, at least to some extent, as `graphql-js` accepts a schema that manually redeclare the introspection types but those are now rejected. It's a bit unclear why `graphql-js` makes that particular exception, in particular since: 1. it makes no such special cases for the introspection fields (being it `__typename`, `__schema` or `type(name)`). Particuarly strange when `__schema` and `__type` are the actual "entry point" for those introspection types in the first place ... 2. it does not seem to otherwise validate that those introspection types are valid, though "manual" definitions seems to be silently discarded so have no impact. But in any case, being consistent with `graphql-js` makes sense, so this patch re-allow definitions of introspection types, but ignores them.
pcmanus
pushed a commit
to pcmanus/federation
that referenced
this pull request
Nov 14, 2022
The fix for apollographql#2237 has been a bit over-zealous, at least to some extent, as `graphql-js` accepts a schema that manually redeclare the introspection types but those are now rejected. It's a bit unclear why `graphql-js` makes that particular exception, in particular since: 1. it makes no such special cases for the introspection fields (being it `__typename`, `__schema` or `type(name)`). Particuarly strange when `__schema` and `__type` are the actual "entry point" for those introspection types in the first place ... 2. it does not seem to otherwise validate that those introspection types are valid, though "manual" definitions seems to be silently discarded so have no impact. But in any case, being consistent with `graphql-js` makes sense, so this patch re-allow definitions of introspection types, but ignores them.
pcmanus
pushed a commit
that referenced
this pull request
Nov 16, 2022
The fix for #2237 has been a bit over-zealous, at least to some extent, as `graphql-js` accepts a schema that manually redeclare the introspection types but those are now rejected. It's a bit unclear why `graphql-js` makes that particular exception, in particular since: 1. it makes no such special cases for the introspection fields (being it `__typename`, `__schema` or `type(name)`). Particuarly strange when `__schema` and `__type` are the actual "entry point" for those introspection types in the first place ... 2. it does not seem to otherwise validate that those introspection types are valid, though "manual" definitions seems to be silently discarded so have no impact. But in any case, being consistent with `graphql-js` makes sense, so this patch re-allow definitions of introspection types, but ignores them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2236