Move gateway post-processing errors into extensions #2380
Conversation
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: d366d2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This align with what the router does, and allow to include post-processing error messages in the response without generating errors we weren't before and thus avoids backward compatibility headaches. Fixes apollographql#2374.
pcmanus
force-pushed
the
f2374-post-processing-errors
branch
from
92733a7
to
868761a
Compare
.changeset/eleven-guests-battle.md
Outdated
| "@apollo/gateway": patch | ||
| --- | ||
|
|
||
| Move gateway post-processing errors into extensions of the response |
There was a problem hiding this comment.
I do think in general these entries should offer a lot of explanation and context, particularly with respect to what the outcome is from the user's perspective.
In this case, references to the original change that necessitates this one and the related issue would both be helpful for building context. Additionally, I'd mention the versions affected here (2.3.0, 2.3.1), what was "broken", and the behavior we restored (and introduced).
There was a problem hiding this comment.
I'm curious as how changeset handles multi-line changelog entries, but we'll see. Happy with your edits otherwise, thanks.
Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
This align with what the router does, and allow to include post-processing error messages in the response without generating errors we weren't before and thus avoids backward compatibility headaches.
Fixes #2374.