Correctly remove useless groups which "downgrade" __typename values
#2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 08ff48b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trevor-scheer
force-pushed
the
trevor/fix-2743-pt-2
branch
from
2d4daf2
to
eb7c971
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Co-authored-by: Sylvain Lebresne <lebresne@gmail.com>
trevor-scheer
force-pushed
the
trevor/fix-2743-pt-2
branch
from
eb7c971
to
08ff48b
Compare
✅ Deploy Preview for apollo-federation-docs canceled.
|
clenfest
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, the query planner was preserving some fetches which were "useless" that would rewrite
__typenamefrom its already-resolved concrete type back to its interface type. This could result in (at least) requested fields being "filtered" from the final result due to the interface's__typenamein the data where the concrete type's__typenamewas expected.Specifically, the solution was compute the path between newly created groups and their parents when we know that it's trivial (
[]). Further along in the planning process, this allows to actually remove the known-useless group.Fixes #2743 (pt 2)