gateway: stop using apollo-server-testing #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
requested review from
trevor-scheer and
martijnwalraven
and removed request for
trevor-scheer
martijnwalraven
approved these changes
Mar 9, 2021
I've been making the assertion in various issues on `apollo-server` that I don't feel like `apollo-server-testing` has much value over using the `executeOperation` method (which was added to AS as part of implementing `apollo-server-testing`) directly. I figured it was worth trying out my suggestion over on this repo (esp when I noticed #553 upgrading `apollo-server-testing`). My opinion is that the version without `createTestClient` is more clear in these particular tests in that adding an intermediate `call` object only serves to obfuscate. The one nice thing that `createTestClient` does is allow you to pass an AST rather than a string for the operation. We could change `executeOperation` to support this directly too, though in this case just changing the tests to not create AST nodes was easy enough.
glasser
force-pushed
the
glasser/no-apollo-server-testing
branch
from
002a8d3
to
f96094c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been making the assertion in various issues on
apollo-serverthat I don'tfeel like
apollo-server-testinghas much value over using theexecuteOperationmethod (which was added to AS as part of implementingapollo-server-testing) directly. I figured it was worth trying out mysuggestion over on this repo (esp when I noticed #553 upgrading
apollo-server-testing). My opinion is that the version withoutcreateTestClientis more clear in these particular tests in that adding anintermediate
callobject only serves to obfuscate.The one nice thing that
createTestClientdoes is allow you to pass an ASTrather than a string for the operation. We could change
executeOperationtosupport this directly too, though in this case just changing the tests to not
create AST nodes was easy enough.