Change query planner API to avoid double parsing and schema building #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnwalraven
changed the title
pcmanus
approved these changes
Apr 1, 2021
trevor-scheer
force-pushed
the
release-0.26.0
branch
from
85935b6
to
a124bf3
Compare
We originally kept the same API we used for the wasm query planner, but that relied on passing in strings for the schema and operation. Since the query planner is now implemented in TypeScript again, we can avoid double parsing and schema building by passing in a composed schema and a parsed operation.
trevor-scheer
force-pushed
the
martijn/query-planner-api-changes
branch
from
32be0ec
to
a6ce5d7
Compare
This was referenced Apr 1, 2021
query-planner-js/src/index.ts
Outdated
| buildOperationContext(planner_ptr.composedSchema, parse(query)), | ||
| options, | ||
| ); | ||
| // TODO: We should change the API to avoid confusion, because |
williamboman
added a commit
to williamboman/federation
that referenced
this pull request
Apr 2, 2021
…tionHeaders * upstream/main: (77 commits) Update CHANGELOGs for release Release Change query planner API to avoid double parsing and schema building (apollographql#628) Update documentation around delivery endpoint option (apollographql#630) Change `buildComposedSchema` test to check for specific directives and types Add `query-planner-js` to `tsconfig.test.json` Release chore(ci): Bump `cache-cargo` seed value. chore(ci): Remove special-case install of `gnu-tar` on `macos` GH Actions. chore(ci): Never try to restore the cache without the `cache-name` for npm chore(ci): Expand upon cache restore keys for Cargo restorations chore(ci): Be explicit about cache restore keys Release Update uplink usage to latest url and update query/generated types (apollographql#626) Release Update changelogs (optionally) REVERT ME: cachebuster Update the thing that TS didn't catch for me :sadface: Rename Endpoint -> Graph and serviceName -> graphName Avoid unnecessary check for undefined ...
williamboman
added a commit
to williamboman/federation
that referenced
this pull request
Apr 2, 2021
…tionHeaders * upstream/main: (77 commits) Update CHANGELOGs for release Release Change query planner API to avoid double parsing and schema building (apollographql#628) Update documentation around delivery endpoint option (apollographql#630) Change `buildComposedSchema` test to check for specific directives and types Add `query-planner-js` to `tsconfig.test.json` Release chore(ci): Bump `cache-cargo` seed value. chore(ci): Remove special-case install of `gnu-tar` on `macos` GH Actions. chore(ci): Never try to restore the cache without the `cache-name` for npm chore(ci): Expand upon cache restore keys for Cargo restorations chore(ci): Be explicit about cache restore keys Release Update uplink usage to latest url and update query/generated types (apollographql#626) Release Update changelogs (optionally) REVERT ME: cachebuster Update the thing that TS didn't catch for me :sadface: Rename Endpoint -> Graph and serviceName -> graphName Avoid unnecessary check for undefined ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally kept the same API we used for the wasm query planner, but that relied on passing in strings for the schema and operation. Since the query planner is now implemented in TypeScript again, we can avoid double parsing and schema building by passing in a composed schema and a parsed operation.
There are remaining inefficiencies in the gateway workflows that we'll want to address in follow-up PRs. In particular, the gateway still calls
buildComposedSchematwice for every update, because it extracts the service list to perform health checks in a separate function. We also parse the supergraph SDL multiple times due to the way functions are structured. Solving this will likely require a rethinking of the way these workflows are composed, and the possible introduction of additional objects (see #580).