Take subtypes into account when matching type conditions to extract representations #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnwalraven
changed the title
martijnwalraven
force-pushed
the
representations-typecondition-fix
branch
from
c6b36c8
to
14acb4c
Compare
pcmanus
approved these changes
Jun 10, 2021
Just added some notes to the PR description, so I'll use that as the commit message. |
martijnwalraven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
executeSelectionSetfunction inexecuteQueryPlan.ts, which is used to extract field values from a result object to build up representations to send to a subgraph, only looked for exact matches of the__typenameto the type condition on an inline fragment. This wasn't an issue before, because the query plans we generated always contained an inline fragment per requested object type, never an abstract type condition.Recent changes in the way we handle scope surfaced this issue however, because it would sometimes wrap things in an additional inline fragment for a parent interface type (this has since been fixed in #805).
Although that means the issue won't arise for now, we do expect to make other changes that would require support for abstract type conditions (avoiding exploding types when they share an interface with a
@keydirective).