This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Improve contrast of colors in the docs #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That sounds excellent and a really great point, @StephenBarlow! 🎉 I'll update the Figma file to include |
Comment on lines
+6
to
+7
| secondary: colors.pink.darker, | ||
| tertiary: colors.teal.darker, |
There was a problem hiding this comment.
Looks awesome! Thanks @StephenBarlow. Since we only step from dark to darker on the second line, should we step up one time on the first as well, from base to dark instead of darker?
There was a problem hiding this comment.
Good Q! Based on @ana-demags's findings, these are the least-dark shades of each brand color that fit the contrast requirements for accessibility. So I believe we should stick with these updates.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using darker versions of brand colors as proposed by @ana-demags
Before:
After:
BTW @ana-demags, I ended up not being able to just use a darker gray for the comment strings, because they ended up looking too similar to regular code. So I'm trying out
orange-darkhere, which I'm partial too because it helps the comments stand out. It's pretty similar to the darker yellow, but that color comes up much less frequently. Let me know what you think!