-
Notifications
You must be signed in to change notification settings - Fork 103
Conversation
exports.onCreateWebpackConfig = ({actions}) => { | ||
actions.setWebpackConfig({ | ||
resolve: { | ||
alias: {path: require.resolve('path-browserify')} | ||
} | ||
}); | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gatsby v3 moves from webpack 4 to 5. In webpack 5, you have to manually set polyfills that webpack 4 previously did for you.
lessOptions: { | ||
modifyVars: mapKeys(colors, (value, key) => `color-${key}`) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update for this plugin moves options to more specific lessOptions
and loaderOptions
"@emotion/core": "^10.0.7", | ||
"@emotion/styled": "^10.0.7", | ||
"@svgr/webpack": "^4.2.0", | ||
"gatsby-plugin-emotion": "^4.0.3", | ||
"gatsby-plugin-less": "^3.0.1", | ||
"gatsby-plugin-react-helmet": "^3.0.2", | ||
"gatsby-plugin-svgr": "^2.0.1", | ||
"@emotion/react": "^11.0.0", | ||
"@emotion/styled": "^11.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update for Emotion 11 and accompanying Gatsby plugin also require @emotion/styled
. Not sure if we still need @emotion/core
or if it's safe to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: the version of space-kit that we're using stil lrelies on @emotion/core, so I'm leaving it in
"gatsby-plugin-emotion": "^6.0.0", | ||
"gatsby-plugin-less": "^5.0.0", | ||
"gatsby-plugin-react-helmet": "^4.0.0", | ||
"gatsby-plugin-svgr": "3.0.0-beta.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an open PR to update this plugin to support Gatsby v3. Someone in the comments published a beta version in the interim until it gets merged.
LGTM @jgarrow! 🥞 |
This PR upgrades the themes to Gatsby v3, upgrading other dependencies where necessary to account for breaking changes from the version bump.
TO DO: