[Security] get queries did not run through validation #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helfer
reviewed
Jun 12, 2017
| @@ -94,6 +94,7 @@ function doRunQuery(options: QueryOptions): Promise<ExecutionResult> { | |||
| logFunction({action: LogAction.request, step: LogStep.status, key: 'operationName', data: options.operationName}); | |||
|
|
|||
| // if query is already an AST, don't parse or validate | |||
| // XXX: This refers the operations-store flow. | |||
There was a problem hiding this comment.
What do you mean by this comment exactly?
There was a problem hiding this comment.
i wanted to disable getting to runQuery with document parsed to eliminate this flow at all.
but i've seen the module-operation-store depends on that "feature".
|
Thanks a lot for the fix @DxCx! I'll release this now, later we can think about whether or not to turn validation back on for persisted queries. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @helfer
i was trying out your
graphql-disable-introspectionmodule,and then got into debug session why it's not working to find out GET Queries was not passing validation pipe.
this patch will make sure GET requests will go through validation as well.
TODO: