Packages and lint #163
Packages and lint #163
Conversation
.gitignore
Outdated
| @@ -4,7 +4,6 @@ coverage | |||
| dist | |||
| node_modules | |||
| npm-debug.log | |||
| package-lock.json | |||
There was a problem hiding this comment.
It is Apollo convention to exclude lock files.
There was a problem hiding this comment.
Do you know why that's the case? Interested in learning more.
Anyways I am willing to drop this though.
There was a problem hiding this comment.
With common use of npm and yarn it can lead to odd issues unless you are aware of the lock files. Additionally with semver there is no reason not to pickup bug fixes.
There was a problem hiding this comment.
I see. I've dropped the commit from my branch.
grantwwu
force-pushed
the
packages_and_lint
branch
from
ae385a1
to
23ad695
Compare
|
Thank you! |
|
@NeoPhi I actually just realized that some of the changes I made deprecations wise are for fairly new versions. In particular, The Moreover neither our Do you think we should revert those changes for some specified period of time? |
|
I'm pulling in the correct versions on a fresh install. As this is only relates to |
Bump some packages to fix security issues. I skimmed the changelogs and didn't notice anything that would cause an issue. Tests still pass.
Fix some tslint deprecations.