Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use graphql-js builtin function separateOperations #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use graphql-js builtin function separateOperations #179

wants to merge 2 commits into from

Commits on May 1, 2018

  1. refactor(loader): utilize separateOperations 

    The loader's size/complexity was greatly reduced by GraphQL's builtin function.
I also refactored the code structure/syntax to make it easier to reason about.
    @detrohutt
    detrohutt committed May 1, 2018
    Configuration menu
    Copy the full SHA
    002d227 View commit details
    Browse the repository at this point in the history

  2. test(loader): adjust tests for separateOperations 

    Mostly this just involved updating the order things were added to definitions.
I had to mess around a bit with the `require` mocking to facilitate new code.
I also unmocked require after each use, which was not being done.
    @detrohutt
    detrohutt committed May 1, 2018
    Configuration menu
    Copy the full SHA
    6db62d9 View commit details
    Browse the repository at this point in the history