Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: allow a space between # and import word in gql files #458

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Loader: allow a space between # and import word in gql files #458

merged 1 commit into from
Jul 23, 2022

Conversation

kidroca
Copy link

@kidroca kidroca commented Jul 10, 2021

Allow the webpack loader to distinct imports written with a space like:

# import "./some/file.graphql"

I've stumbled on this while migrating a parcel project to webpack
In parcel imports work with a space, like in the example here: https://en.parceljs.org/graphQL.html#graphql

The change here allows for both #import and # import syntax to work

@apollo-cla
Copy link

@kidroca: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Match import statements in graphql files
that are written like:
- #import "./some/file.graphql"
- # import "./some/file.graphql"
@kidroca
Copy link
Author

kidroca commented Jul 19, 2022

Hi @hwillson
I'm not sure why this PR is not getting attention, maybe because it's not tied to an issue
Can you check it out or suggest somebody to take a look?

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kidroca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants