Map field TypeScript types shouldn't imply all keys exist #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type `{[k: string]: number}` implies that if you look up ANY string in the
object, you will definitely get a number. This is not appropriate for finite
protobufs.
I regenerated some files with `npm run build && npm run types && node
scripts/gentests.js` though I don't really understand what the tests/data files
are used for.
jsegaran
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
{[k: string]: number}implies that if you look up ANY string in theobject, you will definitely get a number. This is not appropriate for finite
protobufs.
I regenerated some files with
npm run build && npm run types && node scripts/gentests.jsthough I don't really understand what the tests/data filesare used for.