Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Half the time, the optimisticResponse isn't replaced with the actual response #3532

Open
strblr opened this issue Sep 24, 2019 · 3 comments
Open

Comments

@strblr
Copy link

strblr commented Sep 24, 2019

Hello,

Well, everything is in the title. Exactly one time in two, using useQuery, the optimisticResponse isn't replaced with the actual response.

Version

3.0.1 (not using the latest because of this issue)

@audiolion
Copy link

I am having this exact issue, after the query returns the optimistic response is never thrown away with the actual response.

I am using version 3.1.1

@hwillson
Copy link
Member

hwillson commented Oct 2, 2019

Would someone be able to put together a small runnable reproduction that shows this happening, using React Apollo 3.1.2? Thanks!

@audiolion
Copy link

@hwillson After diving into this I realized that another dependencies memoization was causing me to see the optimistic ID still. I did a deep dive into apollo-cache's removeOptimisticUpdate and found it to be working as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants