Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

GraphQL.prototype.forceRenderChildren should use forceUpdate() and not setState({}) #773

Closed
baerrach opened this issue Jun 13, 2017 · 4 comments

Comments

@baerrach
Copy link
Contributor

Buggy Behavior

GraphQL.prototype.forceRenderChildren is using setState to force a re-render, which breaks shallow equals rendering optimizations.

Expected Behavior

Use the React API forceUpdate() instead.

Version

  • apollo-client@1.4.2
  • react-apollo@1.2.0
@stale
Copy link

stale bot commented Jul 5, 2017

This issue has been automatically marked as stale becuase it has not had recent activity. It will be closed if not further activity occurs. Thank you for your contributions to React Apollo!

@settings settings bot removed the wontfix label Jul 8, 2017
@stale
Copy link

stale bot commented Jul 29, 2017

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

@stale
Copy link

stale bot commented Aug 22, 2017

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

@stale stale bot closed this as completed Sep 5, 2017
@stale
Copy link

stale bot commented Sep 5, 2017

This issue has been automatically closed because it has not had recent activity after being marked as no recent activyt. If you belive this issue is still a problem or should be reopened, please reopen it! Thank you for your contributions to React Apollo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant