New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages for non-Chrome browsers. #1568

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
3 participants
@nchevobbe
Copy link
Contributor

nchevobbe commented Jan 22, 2018

Check if error.stack contains error.message, and if not, append it to the error message
printed to the console.
This should fix error messages in Firefox and Safari.

Fix error messages for non-Chrome browsers.
Check if error.stack contains error.message, and if not, append it to the error message
printed to the console.
This should fix error messages in Firefox and Safari.
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Jan 22, 2018

@nchevobbe: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@nchevobbe

This comment has been minimized.

Copy link
Contributor Author

nchevobbe commented Jan 22, 2018

Not sure about this change since I am not familiar with the codebase.
Don't hesitate to tell me what's wrong with this so I can fix it.

@nchevobbe

This comment has been minimized.

Copy link
Contributor Author

nchevobbe commented Jan 23, 2018

This fixes #1567

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jan 24, 2018

@nchevobbe this is fantastic! Thanks so so much!

@jbaxleyiii jbaxleyiii merged commit 76e8b66 into apollographql:master Jan 24, 2018

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/umd/react-apollo.js: 4.79KB < maxSize 4.8KB gzip (39B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.271%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment