Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Testing tools and sample project included in builds #240

Merged
merged 14 commits into from
Oct 31, 2016

Conversation

jbaxleyiii
Copy link
Contributor

@jbaxleyiii jbaxleyiii commented Sep 30, 2016

This adds react-apollo/test-utils to make it easy to unit test your app! Docs to come!

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@stubailo
Copy link
Contributor

What does this mean???

@jbaxleyiii
Copy link
Contributor Author

jbaxleyiii commented Sep 30, 2016

@stubailo this is a WIP to add a number of things!

  1. example apps for people contributing to this project to test / play around / replicate issues (base react, react + flow, typescript)
  2. react-apollo custom testing utilities with examples! i.e. how do I test my query, HOC, and wrapped component in practice with mocked data
  3. flow definitions for people using flow instead of typescript (I'll be adding these to AC once the API updates are done ;) )
  4. Logging hooks which will be used by chrome / safari extensions and react-storybook addons to give a deep insight into what is going on inside your app
  5. Inline documentation which typescript / flow will be able to read with editor support

@jbaxleyiii
Copy link
Contributor Author

Initial additions are testing utilities and a sample project showing test structure

@jbaxleyiii jbaxleyiii changed the title [WIP] full development tooling Testing tools and sample project included in builds Oct 28, 2016
@jbaxleyiii jbaxleyiii merged commit 87bcc44 into master Oct 31, 2016
@jbaxleyiii jbaxleyiii deleted the development-tooling branch October 31, 2016 05:33
@stubailo
Copy link
Contributor

🎉

@@ -111,6 +114,8 @@
"dependencies": {
"hoist-non-react-statics": "^1.2.0",
"invariant": "^2.2.1",
"jest": "^16.1.0-alpha.691b0e22",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just broke our builds
I think it should be moved to dev dependencies

@jbaxleyiii
Copy link
Contributor Author

@edvinerikson sorry about that! New build going out now with it fixed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants