Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Support destructuring onCompleted callback params #2496

Merged
merged 12 commits into from
Mar 6, 2019

Conversation

jozanza
Copy link
Contributor

@jozanza jozanza commented Oct 11, 2018

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

/label typescript

closes #2495

@apollo-cla
Copy link

@jozanza: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the typescript label Oct 11, 2018
@connorjacobsen
Copy link

@hwillson Anything I can do to help with this PR? It looks like the typescript definitions are broken for onComplete without this with stricter typing checks. Can't destructure objects, etc.

@hwillson hwillson added this to Current Sprint in React Apollo Dec 15, 2018
@hwillson hwillson moved this from Current Sprint to Backlog in React Apollo Jan 24, 2019
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for working on this @jozanza!

@hwillson hwillson merged commit 15aa9d0 into apollographql:master Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
React Apollo
  
Backlog
Development

Successfully merging this pull request may close these issues.

onCompleted callback typedef is not destructuring friendly
4 participants