Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Sync & Update versions of react packages #2856

Closed
wants to merge 1 commit into from

Conversation

sapkra
Copy link

@sapkra sapkra commented Mar 9, 2019

This PR will update react including the react test renderer.

The reason is that react and react-dom should always have the same version but the bots are ignoring this rule and for some applications it will produce bugs e.g. broken react hooks.

Fixes #2792

@apollo-cla
Copy link

@sapkra: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@sapkra
Copy link
Author

sapkra commented Mar 9, 2019

I definitely need some help with fixing the breaking changes - can someone have a look? You can see some errors in the logs of the failed builds.

@hwillson
Copy link
Member

Thanks for this @sapkra. We're currently working on updating React Apollo to drop its use of deprecated React API elements. That work overlaps with the items you've listed here, so I'll close this off. Thanks again though - these items will be addressed and ready shortly.

@hwillson hwillson closed this Mar 10, 2019
@sapkra
Copy link
Author

sapkra commented Mar 10, 2019

Ok, nice to hear that.
For the future it would be great if someone of the apollo team can comment on those tickets so that the community is informed and will not invest time in things they are already WIP. 😉

@hwillson
Copy link
Member

Agreed @sapkra - it has been mentioned in a few other issue threads, but communication across many related issues is definitely challenging. We're always striving to improve communication though, so thanks for the reminder!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants