New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shouldComponentUpdate): removed from ApolloProvider #669

Merged
merged 1 commit into from May 1, 2017

Conversation

Projects
None yet
3 participants
@FreddieRidell
Copy link
Contributor

FreddieRidell commented Apr 30, 2017

Is causing issues when ApolloProvider is used with other Providers (eg: react-router).
shouldComponentUpdate is an unnecessary here, it is used to stop unnecessary updates caused by higher components. But as ApolloProvider should be near the top of the tree, it can be assumed that ALL updates passed to is are necessary.

fixes issue: #557

fix(shouldComponentUpdate): removed from ApolloProvider
Is causing issues when ApolloProvider is used with other Providers (eg: react-router).
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Apr 30, 2017

@CodogoFreddie: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented May 1, 2017

@CodogoFreddie this is a great point! And all the test pass! I'm great with this. Can you update the changelog and I'll merge it in!

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented May 1, 2017

@CodogoFreddie I'll update it actually so we can do a release! Thanks again!

@jbaxleyiii jbaxleyiii merged commit 5d9f694 into apollographql:master May 1, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 92.255%
Details

@jbaxleyiii jbaxleyiii referenced this pull request May 1, 2017

Merged

Release 1.1.3 #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment