This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
fix(shouldComponentUpdate): removed from ApolloProvider #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is causing issues when ApolloProvider is used with other Providers (eg: react-router).
|
@CodogoFreddie: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@CodogoFreddie this is a great point! And all the test pass! I'm great with this. Can you update the changelog and I'll merge it in! |
|
@CodogoFreddie I'll update it actually so we can do a release! Thanks again! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is causing issues when
ApolloProvideris used with other Providers (eg: react-router).shouldComponentUpdateis an unnecessary here, it is used to stop unnecessary updates caused by higher components. But asApolloProvidershould be near the top of the tree, it can be assumed that ALL updates passed to is are necessary.fixes issue: #557