New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing properties in MutationOpts (fix for #750) #770

Merged
merged 3 commits into from Jul 5, 2017

Conversation

Projects
None yet
4 participants
@eug48
Copy link
Contributor

eug48 commented Jun 12, 2017

These are based on definitions from apollo-client.

  • Make sure all tests and linter rules pass
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Jun 12, 2017

@eug48: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jun 12, 2017

@eug48 would you be able to update the flow types as well?

@eug48 eug48 changed the title TypeScript: missing properties in MutationOpts (fix for #750) Missing properties in MutationOpts (fix for #750) Jun 13, 2017

@eug48

This comment has been minimized.

Copy link
Contributor Author

eug48 commented Jun 13, 2017

@jbaxleyiii Sure, I've had a go. I don't use flow personally but npm run flow-check still passes.

@beagleknight beagleknight referenced this pull request Jun 20, 2017

Merged

Update js dependencies #1496

4 of 4 tasks complete
@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jul 5, 2017

@eug48 thank you so much! I'll update the changelog once this is merged through!

@jbaxleyiii jbaxleyiii merged commit d81776a into apollographql:master Jul 5, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.295%
Details

@eug48 eug48 deleted the eug48:eug48-patch-issue-750 branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment