New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes flow error: "Named import from module 'react'" #787

Merged
merged 2 commits into from Jun 17, 2017

Conversation

Projects
None yet
3 participants
@pitr12
Copy link
Contributor

pitr12 commented Jun 16, 2017

Fixes: 785

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion
  • If this was a change that affects GitHunt-React, update GitHunt-React and post a link to the PR in the discussion
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Jun 16, 2017

@pitr12: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@pitr12

This comment has been minimized.

Copy link
Contributor Author

pitr12 commented Jun 16, 2017

Hi @helfer, please could you help me investigate why travis build is failing? Actually one test fails, but locally all tests are passing.

@helfer

This comment has been minimized.

Copy link
Member

helfer commented Jun 17, 2017

Looks like it passes now @pitr12. Based on the issue you referenced I'm still not sure if this is the proper way to do it, but if it fixes errors for you and doesn't break any tests, I'm happy to merge it.

@helfer helfer merged commit 2b18b38 into apollographql:master Jun 17, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.384%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment