Add shallow equal comparison

apollographql · Feb 2, 2018 · badba88 · badba88
1 parent e716cfa
commit badba88
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/examples/mutation.re b/examples/mutation.re
@@ -1,4 +1,4 @@
-
+/*
 module PokemonMutation = [%graphql {|
     mutation addPokemon($name: String!) {
        addPokemon(name: $name) {
@@ -33,3 +33,4 @@ render: (_) => {
   </Mutation>
 }
 };
+*/
diff --git a/package.json b/package.json
@@ -39,5 +39,8 @@
     "graphql-tag": "^2.6.1",
     "graphql_ppx": "^0.0.1",
     "reason-react": "^0.3.1"
+  },
+  "dependencies": {
+    "fbjs": "^0.8.16"
   }
 }
diff --git a/src/graphql-types/ReasonApolloQuery.re b/src/graphql-types/ReasonApolloQuery.re
@@ -2,7 +2,11 @@ module type InternalConfig = {let apolloClient: ApolloClient.generatedApolloClie
 
 module QueryFactory = (InternalConfig:InternalConfig) => {
     external castResponse : string => {. "data": Js.Json.t } = "%identity";            
+    external asJsObject : 'a => Js.t({..}) = "%identity";
+
     [@bs.module] external gql : ReasonApolloTypes.gql = "graphql-tag";
+    [@bs.module] external shallowEqual : (Js.t({..}), Js.t({..})) => bool = "fbjs/lib/shallowEqual";
+
 
     type response =
       | Loading
@@ -62,7 +66,7 @@ module QueryFactory = (InternalConfig:InternalConfig) => {
           })
         },
       willReceiveProps: ({state, reduce}) => {
-        if(q##variables != state.variables) {
+        if(!shallowEqual(asJsObject(q##variables), asJsObject(state.variables))) {
           sendQuery(~query=q, ~reduce);
           state;
         } else {