-
Notifications
You must be signed in to change notification settings - Fork 108
Fix mutation promise result type and provide utility to work with the result #132
Conversation
@svsool: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Good one! |
What's required to merge and ship it? |
I reverted |
My initial idea was to use |
Even though it's a breaking change for the referenced code I definitely think we should be getting back the Variant when the mutation is called rather than having to always call the transformation function manually. |
Think so too, I'll add it this week end if I have time |
Fixed in #164 and merged |
Hi, thanks for this library.
I think that mutation promise is wrongly typed and it should be typed as
Js.Promise.t(executionResult)
That means I can't use
convertJsInputToReason
to parse data inJs.Promise.then_
as for instance it's done here https://github.com/tmepple/my-react-app/blob/d47b0b0f2de3d44b1b8dd06f0db2194c0ef987c3/src/components/SignupForm.re#L122 because it's not safeThis PR is intended to fix aforementioned problems