This repository has been archived by the owner on May 26, 2023. It is now read-only.
From functor to function for ApolloInMemoryCache #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drejohnson
commented
Jan 21, 2018
src/ApolloInMemoryCache.re
Outdated
| @@ -34,11 +19,12 @@ type inMemoryCacheRestoreData = Js.Nullable.t(restoreData); | |||
| /* Bind the InMemoryCache class */ | |||
| [@bs.module "apollo-cache-inmemory"] | |||
| [@bs.new] | |||
| external apolloInMemoryCache : inMemoryCacheObject => apolloCache = | |||
| external apolloInMemoryCache : 'a => apolloCache = | |||
There was a problem hiding this comment.
Not sure how to type this instead of using generic type
Gregoirevda
reviewed
Jan 21, 2018
Gregoirevda
approved these changes
Jan 21, 2018
| @@ -67,7 +64,7 @@ module Client = | |||
| { | |||
| let apolloClient = | |||
| ReasonApollo.createApolloClient( | |||
| ~cache=InMemoryCache.cache, | |||
| ~cache=inMemoryCache /* restore method can be piped e.g. inMemoryCache |> restore(window.__APOLLO__) */, | |||
There was a problem hiding this comment.
Awesome to also have the restore available in here
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a function instead of a functor for inMemoryCache