Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorporate new apollo-rs recursion limits #1204

Closed
garypen opened this issue Jun 8, 2022 · 0 comments · Fixed by #1222
Closed

incorporate new apollo-rs recursion limits #1204

garypen opened this issue Jun 8, 2022 · 0 comments · Fixed by #1222
Assignees
@garypen
Labels
enhancement An enhancement to an existing feature

Comments

@garypen
Copy link
Contributor

garypen commented Jun 8, 2022 •
edited

apollo-rs is adding support for enforceable recursion limits which yield a SyntaxTree with errors, rather than panicking due to memory exhaustion.

We can use these limits to provide a more reliable execution environment for the router.

fixes: #1222
@garypen garypen added the enhancement An enhancement to an existing feature label Jun 8, 2022
@garypen garypen self-assigned this Jun 8, 2022
@garypen garypen mentioned this issue Jun 13, 2022
Merged
@garypen garypen closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
enhancement An enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support to router for tracing recursion consumption apollographql/router
1 participant
@garypen