Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to router for tracing recursion consumption #1222

Merged
merged 6 commits into from Jun 13, 2022

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Jun 10, 2022

Now that apollo-rs exports information about parser recursion usage, we
should add that data to our logs.

fixes: #1204

Now that apollo-rs exports information about parser recursion usage, we
should add that data to our logs.
and update apollo parser crate to 0.2.8 to include the recursion fix.
@garypen garypen self-assigned this Jun 10, 2022
@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for apollo-router-docs canceled.

Name Link
🔨 Latest commit d23b596
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/62a362cac42a5b00096c8337

and make sure to re-generate licenses.html
Moving apollo_parser line around and saying it's ok, then complaining in
CircleCI... <grumble, etc...>

Trying again.
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with NIT.

apollo-router/src/spec/query.rs Show resolved Hide resolved
@garypen garypen merged commit b5f803e into main Jun 13, 2022
@garypen garypen deleted the garypen/1204-recursion branch June 13, 2022 12:26
@bnjjj bnjjj added this to the v0.9.4 milestone Jun 14, 2022
This was referenced Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorporate new apollo-rs recursion limits
3 participants