Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File uploads - Nullability integration test #4708

Closed
BrynCooke opened this issue Feb 22, 2024 · 0 comments · Fixed by #4755
Closed

File uploads - Nullability integration test #4708

BrynCooke opened this issue Feb 22, 2024 · 0 comments · Fixed by #4755
Assignees
@nicholascioli

Comments

@BrynCooke
Copy link
Contributor

All of the current tests use a nullable Upload object, but most use-cases will probably make it non-nullable.
@nicholascioli nicholascioli self-assigned this Mar 5, 2024
nicholascioli added a commit that referenced this issue Mar 5, 2024
@nicholascioli
Add integration test for non-nullable files
478b9d9 
resolves #4708

This commit adds a test to ensure that non-nullable file uploads
still work as expected.
nicholascioli added a commit that referenced this issue Mar 5, 2024
@nicholascioli
Add integration test for non-nullable files
0348a29 
resolves #4708

This commit adds a test to ensure that non-nullable file uploads
still work as expected.
@nicholascioli nicholascioli mentioned this issue Mar 5, 2024
Merged
6 tasks
nicholascioli added a commit that referenced this issue Mar 7, 2024
@nicholascioli
Add integration test for non-nullable files
0a909ed 
resolves #4708

This commit adds a test to ensure that non-nullable file uploads
still work as expected.
nicholascioli added a commit that referenced this issue Mar 7, 2024
@nicholascioli
Add integration test for non-nullable files
fcec874 
Existing integration tests for the file uploads plugin did not test for
non-nullable uploads. As this is realistically the more common case,
this commit adds a test to ensure that non-nullable files work as
expected.

This is necessary since the router does some substitution of the
variables for the file upload case which might cause validation issues
if not carefully tested.

Fixes #4708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicholascioli nicholascioli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add integration test for non-nullable files apollographql/router
2 participants
@BrynCooke @nicholascioli