New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File uploads - Nesting integration test #4709
Comments
nicholascioli
added a commit
that referenced
this issue
Mar 5, 2024
resolves #4709 This commit adds some more integration tests for file uploads that test whether files nested in structures still work as expected.
6 tasks
nicholascioli
added a commit
that referenced
this issue
Mar 7, 2024
resolves #4709 This commit adds some more integration tests for file uploads that test whether files nested in structures still work as expected.
nicholascioli
added a commit
that referenced
this issue
Mar 7, 2024
Some tests were missing to ensure that files nested within other GraphQL types still resolved correctly, so this commit addresses that. Fixes #4709 <!-- start metadata --> --- **Checklist** Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [x] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The original file upload spec supports having the uploaded file be nested in either an object or a list. The current tests only test for root-level variables. An example of the kind of request we would want to test is as follows:
The text was updated successfully, but these errors were encountered: