Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing otlp exporter endpoint configuration for http doesn't append the right path #4798

Closed
bnjjj opened this issue Mar 13, 2024 · 0 comments · Fixed by #4801
Closed

tracing otlp exporter endpoint configuration for http doesn't append the right path #4798

bnjjj opened this issue Mar 13, 2024 · 0 comments · Fixed by #4801
Assignees
@bnjjj
Labels
component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it.

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Mar 13, 2024

In our documentation when configuration http endpoint for tracing otlp exporter we say that users should only include the base address of the otlp endpoint.

So for example you'll have to specify the right path for http:

telemetry:
  exporters:
    tracing:
      otlp:
        enabled: true
        endpoint: "http://localhost:4318/v1/traces"
        protocol: http

but not for GRPC:

telemetry:
  exporters:
    tracing:
      otlp:
        enabled: true
        endpoint: "http://localhost:4317"
        protocol: grpc

This inconsistency is due to a bug in opentelemetry-otlp crate, I raised an issue here
@bnjjj bnjjj added the component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. label Mar 13, 2024
@bnjjj bnjjj mentioned this issue Mar 13, 2024
Merged
6 tasks
bnjjj added a commit that referenced this issue Mar 27, 2024
@bnjjj
fix(telemetry): keep consistency between tracing otlp endpoint (#4801)
670b29d 
In our
[documentation](https://www.apollographql.com/docs/router/configuration/telemetry/exporters/tracing/otlp/#endpoint)
when configuration http endpoint for tracing otlp exporter we say that
users should only include the base address of the otlp endpoint. It was
only working for grpc protocol and not http due to [this
bug](open-telemetry/opentelemetry-rust#1618).
This inconsistency is now fixed with a workaround in the router waiting
for the fix in openetelemetry crate.

So for example you'll have to specify the right path for http:

```yaml
telemetry:
  exporters:
    tracing:
      otlp:
        enabled: true
        endpoint: "http://localhost:4318"
        protocol: http
```


Fixes #4798

---------

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@BrynCooke BrynCooke mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(telemetry): keep consistency between tracing otlp endpoint apollographql/router
1 participant
@bnjjj