Simplify boilerplate in the Rhai plugin #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
SimonSapin
force-pushed
the
simon/unmacro
branch
from
1dd4a53
to
dd0ab75
Compare
The crate allows macros to concatenate (possibly variable) identifiers into a single identifier. We can avoid that by using `::` to build up paths instead, and make a module hierarchy that reexports items with desired names. Also replace some single-use functions with closures. This avoids concatenating a name for them.
Instead, inline generic users (which had become one-liners) into their own non-generic (macro-based) users.
originating request.
SimonSapin
force-pushed
the
simon/unmacro
branch
from
dd0ab75
to
c21ba78
Compare
garypen
approved these changes
Jul 20, 2022
| @@ -190,7 +190,7 @@ where | |||
| } | |||
| .or_else(|error: BoxError| async move { | |||
| let errors = vec
There was a problem hiding this comment.
I feel like this is left in by mistake, but...?
SimonSapin
added a commit
that referenced
this pull request
Jul 20, 2022
SimonSapin
added a commit
that referenced
this pull request
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.
Only the last commit should affect behavior (and has a corresponding changelog entry).