Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate query planner cache warm up by default #3801

Merged
merged 3 commits into from Sep 18, 2023
Merged

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Sep 11, 2023

Fix #3766

Cache warm up has been in testing for long enough, and has proven highly ezffective in smoothing out latencies when updating a schema. So this will activate it by default. It can still be deactivated by configuring it to 0:

supergraph:
  query_planning:
    warmed_up_queries: 0

By default, it will now warm up the cache with the 30% most used queries

Description here

Fixes #issue_number

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

Cache warm up has been in testing for long enough, and has proven highly
ezffective in smoothing out latencies when updating a schema. So this
will activate it by default. It can still be deactivated by configuring
it to 0:

```yaml
supergraph:
  query_planning:
    warmed_up_queries: 0
```

By default, it will now warm up the cache with the 30% most used queries
@github-actions
Copy link
Contributor

@Geal, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Sep 11, 2023

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • const - Basic stress test that runs with a constant number of users
  • reload - Reload test over a long period of time at a constant rate of users
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • no-graphos - Basic stress test, no GraphOS.

@bnjjj
Copy link
Contributor

bnjjj commented Sep 11, 2023

Missing a changelog

@Geal Geal merged commit 8d9cedf into dev Sep 18, 2023
12 checks passed
@Geal Geal deleted the geal/activate-warm-up branch September 18, 2023 09:58
@lrlna lrlna mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activate query planner warm up by default
3 participants