Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the busy timer public #4989

Merged
merged 5 commits into from
May 2, 2024
Merged

make the busy timer public #4989

merged 5 commits into from
May 2, 2024

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Apr 19, 2024

the busy timer is used to measure the time spent working on a request outside of waiting for external calls like coprocessors and subgraph calls. It still includes the time spent waiting for other concurrent requests to be handled (wait time in the executor) to show the actual router overhead in the request handling.
This makes the busy timer API public to let native plugins use it when they do their own network calls.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

the busy timer is used to measure the time spent working on a request
outside of waiting for external calls like coprocessors and subgraph
calls. It still includes the time spent waiting for other concurrent
requests to be handled (wait time in the executor) to show the actual
router overhead in the request handling.
This makes the busy timer API public to let native plugins use it when
they do their own network calls.
@Geal Geal requested a review from a team April 19, 2024 14:23

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Apr 19, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

@Geal Geal requested a review from a team as a code owner May 2, 2024 10:23
@Geal Geal merged commit e960155 into dev May 2, 2024
13 of 14 checks passed
@Geal Geal deleted the geal/open-busy-timer branch May 2, 2024 12:37
BrynCooke pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants