Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable default feature in graphql_client #905

Merged
merged 2 commits into from Apr 25, 2022
Merged

enable default feature in graphql_client #905

merged 2 commits into from Apr 25, 2022

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Apr 25, 2022 •
edited

related to #874
removing the default feature can cause build issues in plugins

@Geal
enable default feature in graphql_client
e2817e4 
removing the default feature can cause build issues in plugins
@netlify
Copy link

netlify bot commented Apr 25, 2022 •
edited

✅ Deploy Preview for apollo-router-docs canceled.

Name Link
🔨 Latest commit 37f7571
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/626678c5de5b940008c665ed

@github-actions

This comment has been minimized.

Sign in to view
o0Ignition0o
o0Ignition0o approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linked to #874 but for plugins.
LGTM :shipit:

@Geal Geal enabled auto-merge (squash) April 25, 2022 10:33
@Geal Geal merged commit c77faaf into main Apr 25, 2022
@Geal Geal deleted the geal/graphql_client-features branch April 25, 2022 12:55
@Geal Geal self-assigned this Apr 26, 2022
@BrynCooke BrynCooke added this to the v0.1.0-preview.7 milestone May 4, 2022
@BrynCooke BrynCooke mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjjj bnjjj bnjjj approved these changes

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

@BrynCooke BrynCooke Awaiting requested review from BrynCooke

Assignees

@Geal Geal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Geal @bnjjj @o0Ignition0o @BrynCooke